search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Check CSI sidecar supported versions #227

Closed coulof closed 11 months ago

coulof commented 1 year ago

That script is a helper to update the tables from : https://kubernetes-csi.github.io/docs/sidecar-containers.html

The next goal is to generate the tables from the release pages but... we have to agree upon the metadata and fix the typos :-) (cf. https://github.com/kubernetes-csi/external-attacher/releases with docker pull docker pull registry.k8s.io/sig-storage/csi-attacher:v4.3.0)

coulof commented 1 year ago

/release-note-none

ggriffiths commented 1 year ago

/lgtm

coulof commented 12 months ago

Thanks @ggriffiths. I think this needs a /approve too ;-)

ggriffiths commented 12 months ago

Thanks @ggriffiths. I think this needs a /approve too ;-)

Yes, you'll need @jsafrane for an approval review. I can only provide LGTM :)

ggriffiths commented 12 months ago

/assign @jsafrane

ggriffiths commented 12 months ago

Thanks for taking the time to write this tool. If there's tooling outside the usual bash scripts/makefile scripts I think all of our repos are written in go so it'd make sense to write tooling in go too.

I think there are some K8s scripts out there written in a Python. It's a much better language than bash or go for this use case.

jsafrane commented 11 months ago

/approve sorry it took so long

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coulof, ggriffiths, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment