search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

chore: adopt kubernetes recommand label #228

Closed mowangdk closed 11 months ago

mowangdk commented 1 year ago

Adopt kubernetes recommand label

ref: https://github.com/kubernetes-csi/external-snapshotter/pull/844
k8s-ci-robot commented 1 year ago

Welcome @mowangdk!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @mowangdk. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nixpanic commented 1 year ago

/ok-to-test /lgtm

mowangdk commented 1 year ago

@nixpanic all tests passed, ptal~

mowangdk commented 1 year ago

/lgtm

I think you need to add a release note section in the initial PR description. Once that is done, the do-not-merge/release-note-needed label should be removed, and you can assign this PR to one of the maintainers for approval.

okay, thank you very much!

mowangdk commented 1 year ago

@xing-yang ptal~

xing-yang commented 11 months ago

Can you apply this change in ttps://github.com/kubernetes-csi/external-snapshotter/pull/844?

mowangdk commented 11 months ago

Can you apply this change in ttps://github.com/kubernetes-csi/external-snapshotter/pull/844?

okay, I'm not familiar with subtree development, do I need to switch subtree branches in external-snapshotter or just paste the changes in?

xing-yang commented 11 months ago

/lgtm /approve

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mowangdk, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment