search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

Fix CI jobs on Kubernetes master #23

Closed msau42 closed 5 years ago

msau42 commented 5 years ago

Kubernetes master changed the way that versions are determined, which requires a new kind build.

This PR has 3 changes:

  1. Use a master commit of kind that includes the fix for Kubernetes master.
  2. Use git clone instead of git checkout (shallow) to source Kubernetes. This lets kind correctly figure out the Kubernetes release tag.
  3. Build kind with make install. The kind fix was not working correctly when built with go build.

This has been tested in https://github.com/kubernetes-csi/csi-driver-host-path/pull/77

k8s-ci-robot commented 5 years ago

@msau42: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [msau42] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msau42 commented 5 years ago

/release-note-none /assign @pohly @jsafrane

jsafrane commented 5 years ago

/lgtm