search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Bump go build version to 1.21 #238

Closed ConnorJC3 closed 7 months ago

ConnorJC3 commented 7 months ago

Bumps the go version from 1.20 to 1.21, needed for latest Kubernetes version which relies on the slices package in the standard library that was made available in 1.21.

Created for and required by https://github.com/kubernetes-csi/external-provisioner/pull/1068

k8s-ci-robot commented 7 months ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ConnorJC3 Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 7 months ago

/retest

jsafrane commented 7 months ago

/close I approved https://github.com/kubernetes-csi/csi-release-tools/pull/240, even though your PR is older. That one had a release note ;-).

k8s-ci-robot commented 7 months ago

@jsafrane: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/csi-release-tools/pull/238#issuecomment-1822622198): >/close >I approved https://github.com/kubernetes-csi/csi-release-tools/pull/240, even though your PR is older. That one had a release note ;-). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.