search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
21 stars 71 forks source link

Update go version to 1.21 to match k/k #240

Closed dannawang0221 closed 7 months ago

dannawang0221 commented 7 months ago

Refer to https://github.com/kubernetes/kubernetes/blob/master/.go-version

Update go version to 1.21
dannawang0221 commented 7 months ago

/assign @sunnylovestiramisu

sunnylovestiramisu commented 7 months ago

/assign @xing-yang

sunnylovestiramisu commented 7 months ago

/retest

sunnylovestiramisu commented 7 months ago

New csi-test release version created: https://github.com/kubernetes-csi/csi-test/releases/tag/v5.2.0

sunnylovestiramisu commented 7 months ago

Can you change this line to https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L243 v5.2.0?

xing-yang commented 7 months ago

Hi @pohly,

We are getting the following error in every PR submitted to csi-release-tools repo now. Any idea what might have caused this?

+ ./pull-test.sh
+ pwd
+ CSI_RELEASE_TOOLS_DIR=/home/prow/go/src/github.com/kubernetes-csi/csi-release-tools
+ cd /home/prow/go/src/github.com/kubernetes-csi/csi-test
+ git subtree pull --squash --prefix=release-tools /home/prow/go/src/github.com/kubernetes-csi/csi-release-tools master
fatal: working tree has modifications.  Cannot add.
pohly commented 7 months ago

Workaround is in https://github.com/kubernetes-csi/csi-release-tools/pull/243

jsafrane commented 7 months ago

/retest

jsafrane commented 7 months ago

/lgtm

jsafrane commented 7 months ago

/approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dannawang0221, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment