Add test-logcheck target

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects

Apache License 2.0

21 stars 71 forks source link

Add test-logcheck target #251

Closed jsafrane closed 1 month ago

jsafrane commented 1 month ago

The new test-logcheck + verify-logcheck.sh script checks for correct klog usage.

It's optional and must be explicitly requested in the main Makefile by adding:

test: test-logcheck

Added support for structured and contextual logging check

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

bells17 commented 1 month ago

Thank you! /lgtm