search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

build windows binaries with .exe suffix #30

Closed msau42 closed 5 years ago

msau42 commented 5 years ago

so that it doesn't override linux binary

k8s-ci-robot commented 5 years ago

@msau42: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [msau42] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msau42 commented 5 years ago

/assign @ddebroy

msau42 commented 5 years ago

Tested in https://github.com/kubernetes-csi/csi-driver-host-path/pull/93

ddebroy commented 5 years ago

/lgtm

ddebroy commented 5 years ago

Given we don't have any requirements for non EXE binaries (like DLLs) this looks good.

msau42 commented 5 years ago

/release-note-none