search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

Add custom e2e job to prow.sh #44

Closed mkimuram closed 4 years ago

mkimuram commented 5 years ago

What type of PR is this? This enables prow.sh in csi-release-tool to run custom e2e tests.

What this PR does / why we need it: This PR is needed for csi drivers that don't have dynamic provisioner, like NFS and iSCSI, to run custom e2e binary in CI jobs.

Below are the status for cstom e2e binary codes in NFS and iSCSI driver:

Special notes for your reviewer: @pohly @msau42 @mathu97

This PR is tested with below csi NFS driver repo (I found that https://github.com/kubernetes-csi/csi-driver-nfs/pull/14 is doing almost the same thing, but it seems that it is not yet completed.). https://github.com/mkimuram/csi-driver-nfs/tree/custom-e2e

Below commands will make custom e2e tests for csi NFS driver from .prow.sh in above csi-drver-nfs repo. 

# sed -i -e 's/#CSI_PROW_BUILD_JOB=/CSI_PROW_BUILD_JOB=/' -e 's/#CSI_PROW_TESTS=/CSI_PROW_TESTS=/' .prow.sh
# export GO111MODULE=on
# ./.prow.sh

I will make a PR for CSI NFS driver above, once this PR is merged. (Also, I'm thinking about adding this to CSI iSCSI driver and enable CI job on test-infra repo, as commented in https://github.com/kubernetes-csi/csi-driver-iscsi/pull/17#issuecomment-546512229 .)

k8s-ci-robot commented 5 years ago

@mkimuram: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

Welcome @mkimuram!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 5 years ago

Hi @mkimuram. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkimuram To complete the pull request process, please assign pohly You can assign the PR to them by writing /assign @pohly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 5 years ago

https://github.com/kubernetes-csi/csi-driver-nfs/pull/14 was complete, we just got stuck because the NFS driver didn't work in the Prow environment (https://github.com/kubernetes-csi/csi-driver-nfs/pull/14#issuecomment-502545228).

If you look at that PR, you'll see that it worked without modifying csi-release-tools. Are you sure that you need these modifications here?

mkimuram commented 5 years ago

@pohly

Thank you for your explanation. I understand that modification is done on driver repo's .prow.sh and it should work. This will be good enough, for there won't be so many drivers that require this modification.

I will consider applying the similar changes to csi-driver-iscsi.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 4 years ago

@fejta-bot: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/csi-release-tools/pull/44#issuecomment-609978361): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.