search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

Support make container on arm64 architecture #59

Closed wangzihao3 closed 4 years ago

wangzihao3 commented 4 years ago

Fixes https://github.com/kubernetes-csi/external-provisioner/issues/381

- judge the arch in build.make, set BASE_IMAGE to discolix/static:latest
  when ARCH is arm64.
- todo: need to modify the FROM part in Dockerfile.

Signed-off-by: wangzihao wangzihao18@huawei.com

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wangzihao18 To complete the pull request process, please assign saad-ali You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 years ago

Welcome @Wangzihao18!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

Hi @Wangzihao18. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

k8s-ci-robot commented 4 years ago

@wangzihao3: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

pohly commented 4 years ago

Superseded by PR #87, except that arm64 is not enabled yet?

cyb70289 commented 4 years ago

Superseded by PR #87, except that arm64 is not enabled yet?

Hi @pohly , I see arm64 is not enabled in prow.sh, CSI_PROW_BUILD_PLATFORMS configvar. Is it possible to enabled arm64 build? I can help with a PR. Thanks.

pohly commented 4 years ago

@cyb70289 yes, please verify that all of the Kubernetes-CSI repos build for ARM, then submit a PR against csi-release-tools which adds arm64. That then will be rolled out to the other repos before the next sidecar releases.

cyb70289 commented 4 years ago

@pohly thank you. I tested node-driver-registrar, external-attacher, external-privisioner, external-snapshotter, external-resizer, livenessprobe, csi-driver-host-path. They all build cleanly on Arm64. I tried make build and make container. Is it okay I propose a PR to enable Arm64 in csi release tool?

pohly commented 4 years ago

Yes, please do.

cyb70289 commented 4 years ago

PR created https://github.com/kubernetes-csi/csi-release-tools/pull/91

fejta-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 4 years ago

@fejta-bot: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/csi-release-tools/pull/59#issuecomment-659162973): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.