search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

Run travis builds for ppc64le #62

Closed Pensu closed 4 years ago

Pensu commented 4 years ago

This is in ref to #48 and an extension to the PR: #47. This PR allows the travis build to run for ppc64le env as well. Here are the changes done:

1) Add image name based on arch. For amd64 image names remains same, for ppc64le, add -ppc64le to the image name. 2) Add arch variable in travis.yaml to run the build on both amd64 and ppc64le archs and make go version same for all builds. 3) Disable shellcheck for ppc64le, as shellcheck is not available for the arch yet. (A issue has been opened: https://github.com/koalaman/shellcheck/issues/1767) 3) Download the correct dep binary for the given arch.

k8s-ci-robot commented 4 years ago

@Pensu: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

Hi @Pensu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pensu To complete the pull request process, please assign saad-ali You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Pensu commented 4 years ago

Hi @msau42 @pohly @saad-ali, can you please help in reviewing this? Thanks.

msau42 commented 4 years ago

/ok-to-test

msau42 commented 4 years ago

We are in the process of moving away from travis to prow for image releasing. Do we know if prow supports cross builds?

Pensu commented 4 years ago

Closing in favor of #68