build for multiple platforms only in CI, add s390x

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects

Apache License 2.0

22 stars 73 forks source link

build for multiple platforms only in CI, add s390x #76

Closed pohly closed 4 years ago

pohly commented 4 years ago

Developers should not be forced to build for all platforms by default. We also don't want to copy-and-paste the go invocation for each new platform.

To address both, the target platform(s) are now configurable via BUILD_PLATFORMS and additional platforms are only enabled in the Prow CI.

For now this serves as a test that the source actually compiles for multiple platforms. Building images for different target platforms is a different problem.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pohly commented 4 years ago

This replaces PR #73 .

/release-note-none

pohly commented 4 years ago

Test build is here: https://prow.k8s.io/log?id=1235150069494190080&job=pull-kubernetes-csi-external-provisioner-unit

msau42 commented 4 years ago

/lgtm