search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

filter-junit: Fix gofmt error #93

Closed animeshk08 closed 4 years ago

animeshk08 commented 4 years ago

Signed-off-by: Animesh Kumar animuz111@gmail.com

This commit is aimed to fix the gofmt error in this PR: https://github.com/kubernetes-csi/csi-driver-smb/pull/28

Build log can be found here: https://travis-ci.org/github/kubernetes-csi/csi-driver-smb/builds/699596732#L505

k8s-ci-robot commented 4 years ago

Hi @animeshk08. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
animeshk08 commented 4 years ago

I apologize for the multiple iterations on this work.

animeshk08 commented 4 years ago

/release-note-none

pohly commented 4 years ago

The underlying issue is that the code is expected to comply with restrictions that aren't tested in the repo itself. In other words, we need golint testing here.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshk08, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment