search

kubernetes-csi / csi-release-tools

shared build and test files used by kubernetes-csi projects
Apache License 2.0
22 stars 73 forks source link

update go version to 1.14.4 #96

Closed humblec closed 4 years ago

humblec commented 4 years ago

Signed-off-by: Humble Chirammal hchiramm@redhat.com

k8s-ci-robot commented 4 years ago

@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec To complete the pull request process, please assign pohly You can assign the PR to them by writing /assign @pohly in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-release-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 4 years ago

I don't think we came to a full conclusion on which Go version we want to switch to: https://kubernetes.slack.com/archives/C8EJ01Z46/p1596537153179300

Apparently 1.14 has potential runtime issues that are severe enough that Kubernetes is skipping it.

pohly commented 4 years ago

We decided to go straight for 1.15, in order to be aligned with Kubernetes 1.19.0 and Docker which both skip 1.14 because of runtime issues (https://github.com/kubernetes/kubernetes/issues/92521).

pohly commented 4 years ago

PR #97 replaces this one here.

k8s-ci-robot commented 4 years ago

@humblec: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pohly commented 4 years ago

/close

We went straight to Go 1.15 instead.

k8s-ci-robot commented 4 years ago

@pohly: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/csi-release-tools/pull/96#issuecomment-673662156): >/close > >We went straight to Go 1.15 instead. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.