search

kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
159 stars 148 forks source link

Assert NodePublishVolume behavior for single node single writer volumes #421

Closed chrishenzie closed 7 months ago

chrishenzie commented 1 year ago

What type of PR is this? /kind feature

What this PR does / why we need it: This PR adds a test case that asserts SINGLE_NODE_SINGLE_WRITER volumes can only be published at one target path on a node.

Which issue(s) this PR fixes: Fixes #420

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add node publish volume test for volume with SINGLE_NODE_SINGLE_WRITER access mode
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrishenzie Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval by writing /assign @xing-yang in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chrishenzie commented 1 year ago

/sig storage /cc @msau42 /cc @jsafrane /hold

Need to cut a release of the hostpath driver and update this PR to use that version.

jsafrane commented 1 year ago

/retest TestMyDriverWithCustomTargetPaths failed

chrishenzie commented 1 year ago

I think this will continue failing until we've updated the hostpath driver version to v1.11, but we'll need to cut a release of it first

chrishenzie commented 1 year ago

It looks like it failed because:

Go version for building the component: CSI_PROW_GO_VERSION_BUILD=1.18

...

# Building the hostpath driver
../../vendor/k8s.io/component-base/metrics/registry.go:35:29: undefined: atomic.Bool
note: module requires Go 1.19

Bumped the go version to 1.19 and testing now

chrishenzie commented 1 year ago

Not seeing where the error is originating from /retest

jsafrane commented 1 year ago

/retest

jsafrane commented 1 year ago

New release-tools, new errors.

s: "target path creation command /home/prow/go/pkg/csiprow.LB7s91MBEk/mkdir_in_pod.sh failed: exit status 1",

I did not dig further

k8s-ci-robot commented 1 year ago

@chrishenzie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-test 89676a68f3ac633d9e1d43b00c6736374d6c0c17 link true /test pull-kubernetes-csi-csi-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

chrishenzie commented 1 year ago

/remove-lifecycle stale

I have a partially implemented test, just needs debugging

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/csi-test/pull/421#issuecomment-2005647797): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the PR is closed > >You can: >- Reopen this PR with `/reopen` >- Mark this PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.