search

kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
154 stars 147 forks source link

Allow drivers to support the GROUP_CONTROLLER_SERVICE capability #450

Closed nixpanic closed 1 year ago

nixpanic commented 1 year ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

The external-snapshotter is going to support Volume Group Snapshots, so drivers will return the capability as well.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

There are no tests for the new Volume Group Snapshot yet. kubernetes-csi/csi-driver-host-path#399 is the first PR for a driver to support the new ALPHA feature.

Does this PR introduce a user-facing change?:

The external-snapshotter is going to support [Volume Group Snapshots](kubernetes/enhancements#1551), so drivers will return the `GROUP_CONTROLLER_SERVICE` capability as well.
xing-yang commented 1 year ago

/assign

xing-yang commented 1 year ago

Can you add a release note?

xing-yang commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment