search

kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
154 stars 147 forks source link

avoid close of closed conn when the controller address of config is empty #464

Closed carlory closed 1 year ago

carlory commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

avoid close of closed conn when the controller address of config is empty

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
carlory commented 1 year ago

/assign @jsafrane

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 1 year ago

avoid close of closed conn when the controller address of config is empty

Was that actually causing problems? I'm just curious.

carlory commented 1 year ago

It is not clear at present, I just discovered this phenomenon in the process of reading the code