search

kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
154 stars 147 forks source link

Update mock for ControllerModifyVolume #492

Closed ConnorJC3 closed 9 months ago

ConnorJC3 commented 10 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

What this PR does / why we need it:

Bumps the CSI spec dependency to v1.9.0 and regenerates the controller mock to account for the new ControllerModifyVolume RPC.

Which issue(s) this PR fixes:

Sub-dependency of https://github.com/kubernetes-csi/external-provisioner/issues/952 and https://github.com/kubernetes-csi/external-resizer/issues/314

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

Bumps the CSI spec dependency to v1.9.0 and regenerates the controller mock to account for the new ControllerModifyVolume RPC.
xing-yang commented 9 months ago

Can you please rebase so that we can get this merged?

ConnorJC3 commented 9 months ago

@xing-yang rebased, should be good now

xing-yang commented 9 months ago

/lgtm /approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment