search

kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
151 stars 147 forks source link

Check ContentSource when creating volume from snapshot #497

Open palvarez89 opened 8 months ago

palvarez89 commented 8 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind flake

/kind feature

What this PR does / why we need it:

When developing our CSI, the volumes being created from snapshots were being deleted automatically, because the response wasn't including ContentSource information. Sanity tests were passing in our environment, and it was confusing to see that the tests were testing this particular case (creating a volume from snapshot) and the result was successful.

This commit made the sanity tests in our end fail with our CSI issue.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added check to ensure ContentSource is set when creating a volume from a snapshot.
k8s-ci-robot commented 8 months ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
linux-foundation-easycla[bot] commented 8 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 8 months ago

Welcome @palvarez89!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 8 months ago

Hi @palvarez89. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: palvarez89 Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xing-yang commented 8 months ago

Please sign CLA.

xing-yang commented 8 months ago

/ok-to-test

xing-yang commented 8 months ago

Can you add a release note?

palvarez89 commented 8 months ago

Can you add a release note?

I hadn't formatted correctly the markdown, and it wasn't showing. I've now fixed that and improved it a bit.

I'll try to get my company to sign that CLA asap

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

palvarez89 commented 5 months ago

/remove-lifecycle stale

Need to poke some people...

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

palvarez89 commented 2 months ago

/remove-lifecycle stale

Apoloigies this is taking so long