kubernetes-csi / csi-test

CSI test frameworks
Apache License 2.0
151 stars 147 forks source link

bump CSI spec to v1.10.0 #519

Closed huww98 closed 1 week ago

huww98 commented 4 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug

/kind cleanup

/kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

bump CSI spec to next version

and fix the build failure

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This uses an unreleased version of CSI spec. If we are not in hurry merging this, I'll update this PR when a new release is available.

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/csi-test/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 months ago

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
huww98 commented 2 weeks ago

Updated this PR to use the released version of CSI spec.

carlbraganza commented 2 weeks ago

I hope I have permission to do this:

/ok-to-test

carlbraganza commented 2 weeks ago

@huww98 I created https://github.com/kubernetes-csi/csi-test/pull/545 to add the SnapshotMetadata service, based on the work you did here. I can close my PR in favor of this PR if the functionality gets added here, or will refactor to only add SnapshotMeta in my PR if this gets in first!

huww98 commented 1 week ago

closing because #545 has been merged, which includes this PR.