Closed huww98 closed 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: huww98 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @huww98. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Updated this PR to use the released version of CSI spec.
I hope I have permission to do this:
/ok-to-test
@huww98 I created https://github.com/kubernetes-csi/csi-test/pull/545 to add the SnapshotMetadata
service, based on the work you did here. I can close my PR in favor of this PR if the functionality gets added here, or will refactor to only add SnapshotMeta
in my PR if this gets in first!
closing because #545 has been merged, which includes this PR.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
bump CSI spec to next version
and fix the build failure
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This uses an unreleased version of CSI spec. If we are not in hurry merging this, I'll update this PR when a new release is available.
Does this PR introduce a user-facing change?: