Open huww98 opened 6 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: huww98 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @huww98. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
PR needs rebase.
What type of PR is this?
/kind bug /kind cleanup
What this PR does / why we need it:
Use MakeCreateVolumeReq for all tests that does not care how volumes are created.
This fixes several places where TestVolumeSize is not considered.
MakeCreateVolumeReq() itself is modified to not pass LimitBytes, to match most existing cases.
Which issue(s) this PR fixes:
Fixes some failures due to TestVolumeSize not passed to CSI.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: