search

kubernetes-csi / external-health-monitor

This repo contains sidecar controller and agent for volume health monitoring.
Apache License 2.0
66 stars 52 forks source link

Support contextual logging #246

Closed bells17 closed 5 months ago

bells17 commented 6 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

I've updated the klog functions used within csi-lib-utils to contextual logging functions, following the guidelines below: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

In a previous PR below, I addressed structured logging, but I realized that I only handled structured logging and did not address contextual logging. https://github.com/kubernetes-csi/external-health-monitor/pull/208

Therefore, in this PR, I have addressed contextual logging.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I have also updated csi-release-tools to use the newly added logcheck feature.

Squashed 'release-tools/' changes from adb3af9d..49676850
49676850 Merge pull request #254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 49676850e1c9c41b263720e1756322d9e35edd73

Does this PR introduce a user-facing change?:

Added support for contextual logging.
k8s-ci-robot commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

bells17 commented 6 months ago

/wg structured-logging /area logging /priority important-longterm /kind cleanup /cc @kubernetes/wg-structured-logging-reviews

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#what-to-include-in-the-pull-request

k8s-ci-robot commented 6 months ago

@bells17: GitHub didn't allow me to request PR reviews from the following users: kubernetes/wg-structured-logging-reviews.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-csi/external-health-monitor/pull/246#issuecomment-2093181401): >/wg structured-logging >/area logging >/priority important-longterm >/kind cleanup >/cc @kubernetes/wg-structured-logging-reviews > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 6 months ago

@bells17: The label(s) area/logging cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-csi/external-health-monitor/pull/246#issuecomment-2093181401): >/wg structured-logging >/area logging >/priority important-longterm >/kind cleanup >/cc @kubernetes/wg-structured-logging-reviews > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bells17 commented 6 months ago

/cc @pohly (I did cc because @pohly is the only member of @kubernetes/wg-structured-logging-reviews within kubernetes-csi org.)

bells17 commented 6 months ago

/hold

https://kubernetes.slack.com/archives/C09QZFCE5/p1715087356356999

bells17 commented 5 months ago

/hold cancel logcheck crash was fixed.

jsafrane commented 5 months ago

/lgtm /approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bells17, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-health-monitor/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment