kubernetes-csi / external-provisioner

Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint
Apache License 2.0
328 stars 318 forks source link

build(deps): bump the github-dependencies group with 39 updates #1157

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 4 months ago

Bumps the github-dependencies group with 39 updates:

Package From To
github.com/google/uuid 1.5.0 1.6.0
github.com/miekg/dns 1.1.57 1.1.58
github.com/prometheus/client_golang 1.17.0 1.18.0
google.golang.org/grpc 1.60.0 1.61.0
google.golang.org/protobuf 1.31.0 1.32.0
github.com/onsi/ginkgo/v2 2.13.2 2.15.0
github.com/onsi/gomega 1.30.0 1.31.1
github.com/emicklei/go-restful/v3 3.11.0 3.11.2
github.com/evanphx/json-patch 5.7.0+incompatible 5.9.0+incompatible
github.com/evanphx/json-patch/v5 5.7.0 5.9.0
github.com/go-logr/logr 1.3.0 1.4.1
github.com/go-openapi/jsonpointer 0.20.1 0.20.2
github.com/go-openapi/jsonreference 0.20.3 0.20.4
github.com/go-openapi/swag 0.22.5 0.22.6
github.com/grpc-ecosystem/grpc-gateway/v2 2.18.1 2.19.1
github.com/prometheus/common 0.45.0 0.46.0
go.etcd.io/etcd/api/v3 3.5.11 3.5.12
go.etcd.io/etcd/client/pkg/v3 3.5.11 3.5.12
go.etcd.io/etcd/client/v3 3.5.11 3.5.12
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.46.1 0.48.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp 0.46.1 0.48.0
go.opentelemetry.io/otel 1.21.0 1.23.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace 1.21.0 1.23.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc 1.21.0 1.23.1
go.opentelemetry.io/otel/metric 1.21.0 1.23.1
go.opentelemetry.io/otel/sdk 1.21.0 1.23.1
go.opentelemetry.io/otel/trace 1.21.0 1.23.1
go.opentelemetry.io/proto/otlp 1.0.0 1.1.0
golang.org/x/crypto 0.17.0 0.18.0
golang.org/x/mod 0.14.0 0.15.0
golang.org/x/net 0.19.0 0.20.0
golang.org/x/oauth2 0.15.0 0.16.0
golang.org/x/sync 0.5.0 0.6.0
golang.org/x/sys 0.15.0 0.16.0
golang.org/x/term 0.15.0 0.16.0
golang.org/x/tools 0.16.1 0.17.0
google.golang.org/genproto 0.0.0-20231030173426-d783a09b4405 0.0.0-20240116215550-a9fa1716bcac
google.golang.org/genproto/googleapis/api 0.0.0-20231106174013-bbf56f31fb17 0.0.0-20240125205218-1f4bbc51befe
google.golang.org/genproto/googleapis/rpc 0.0.0-20231106174013-bbf56f31fb17 0.0.0-20240125205218-1f4bbc51befe

Updates github.com/google/uuid from 1.5.0 to 1.6.0

Release notes

Sourced from github.com/google/uuid's releases.

v1.6.0

1.6.0 (2024-01-16)

Features

Bug Fixes

Changelog

Sourced from github.com/google/uuid's changelog.

1.6.0 (2024-01-16)

Features

Bug Fixes

Commits


Updates github.com/miekg/dns from 1.1.57 to 1.1.58

Commits


Updates github.com/prometheus/client_golang from 1.17.0 to 1.18.0

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.18.0

What's Changed

  • [FEATURE] promlint: Allow creation of custom metric validations. #1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #1360

New Contributors

Full Changelog: https://github.com/prometheus/client_golang/compare/v1.17.0...v1.18.0

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.18.0 / 2023-12-22

  • [FEATURE] promlint: Allow creation of custom metric validations. #1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #1360
Commits
  • 53be91d Revert "change api http.client to interface"
  • 1a2d072 Add 1.18 changelog
  • 239b123 Merge pull request #1387 from tsipo/main
  • 3f8bd73 Merge pull request #1370 from prometheus/dependabot/go_modules/tutorial/whats...
  • 5e55b31 Bump google.golang.org/grpc from 1.53.0 to 1.56.3 in /tutorial/whatsup
  • e96fb18 Merge pull request #1401 from prometheus/dependabot/go_modules/golang.org/x/s...
  • 2a8fc90 Bump golang.org/x/sys from 0.13.0 to 0.15.0
  • 24d59e9 change client to interface, allow override by other implementations (e.g. git...
  • 80d3f0b Normalize empty help values in CollectAndCompare (#1378)
  • 3f80cd1 Add example of NewConstMetricWithCreatedTimestamp (#1375)
  • Additional commits viewable in compare view


Updates google.golang.org/grpc from 1.60.0 to 1.61.0

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.61.0

New Features

  • resolver: provide method, AuthorityOverrider, to allow resolver.Builders to override the default authority for a ClientConn. (EXPERIMENTAL) (#6752)
  • xds: add support for mTLS Credentials in xDS bootstrap (gRFC A65) (#6757)
  • server: add grpc.WaitForHandlers ServerOption to cause Server.Stop to block until method handlers return. (EXPERIMENTAL) (#6922)

Performance Improvements

  • grpc: skip compression of empty messages as an optimization (#6842)
  • orca: use atomic pointer to improve performance in server metrics recorder (#6799)

Bug Fixes

  • client: correctly enable TCP keepalives with OS defaults on windows (#6863)
  • server: change some stream operations to return UNAVAILABLE instead of UNKNOWN when underlying connection is broken (#6891)
  • server: fix GracefulStop to block until all method handlers return (v1.60 regression). (#6922)
  • server: fix two bugs that could lead to panics at shutdown when using NumStreamWorkers (EXPERIMENTAL). (#6856)
  • reflection: do not send invalid descriptors to clients for files that cannot be fully resolved (#6771)
  • xds: don't fail channel/server startup when xds creds is specified, but bootstrap is missing certificate providers (#6848)
  • xds: Atomically read and write xDS security configuration client side (#6796)
  • xds/server: fix RDS handling for non-inline route configs (#6915)

Release v1.60.1

Bug Fixes

  • server: fix two bugs that could lead to panics at shutdown when using NumStreamWorkers (experimental feature).
Commits
  • 8167bc3 Change version to 1.61.0 (#6936)
  • 52e2363 test/xds: Use different import path for gRPC Messages (#6933)
  • 67e50be transport: Remove redundant if in handleGoAway (#6930)
  • e96f521 alts: Extract AuthInfo after handshake in ALTS e2e test. (#6931)
  • 987df13 metadata: move FromOutgoingContextRaw() to internal (#6765)
  • 61eab37 server: block GracefulStop on method handlers and make blocking optional for ...
  • ddd377f xds/server: fix RDS handling for non-inline route configs (#6915)
  • 8b455de removing Roots deprecated Subjects field in tests (#6907)
  • 953d12a alts: Forward-fix of ALTS queuing of handshake requests. (#6906)
  • 6ce73bf internal/transport: convert ConnectionError to Unavailable status when wr...
  • Additional commits viewable in compare view


Updates google.golang.org/protobuf from 1.31.0 to 1.32.0

Updates github.com/onsi/ginkgo/v2 from 2.13.2 to 2.15.0

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.15.0

2.15.0

Features

  • JUnit reports now interpret Label(owner:X) and set owner to X. [8f3bd70]
  • include cancellation reason when cancelling spec context [96e915c]

Fixes

  • emit output of failed go tool cover invocation so users can try to debug things for themselves [c245d09]
  • fix outline when using nodot in ginkgo v2 [dca77c8]
  • Document areas where GinkgoT() behaves differently from testing.T [dbaf18f]
  • bugfix(docs): use Unsetenv instead of Clearenv (#1337) [6f67a14]

Maintenance

  • Bump to go 1.20 [4fcd0b3]

v2.14.0

2.14.0

Features

You can now use GinkgoTB() when you need an instance of testing.TB to pass to a library.

Prior to this release table testing only supported generating individual Its for each test entry. DescribeTableSubtree extends table testing support to entire testing subtrees - under the hood DescrieTableSubtree generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.

  • Introduce DescribeTableSubtree [65ec56d]
  • add GinkgoTB() to docs [4a2c832]
  • Add GinkgoTB() function (#1333) [92b6744]

Fixes

  • Fix typo in internal/suite.go (#1332) [beb9507]
  • Fix typo in docs/index.md (#1319) [4ac3a13]
  • allow wasm to compile with ginkgo present (#1311) [b2e5bc5]

Maintenance

  • Bump golang.org/x/tools from 0.16.0 to 0.16.1 (#1316) [465a8ec]
  • Bump actions/setup-go from 4 to 5 (#1313) [eab0e40]
  • Bump github/codeql-action from 2 to 3 (#1317) [fbf9724]
  • Bump golang.org/x/crypto (#1318) [3ee80ee]
  • Bump golang.org/x/tools from 0.14.0 to 0.16.0 (#1306) [123e1d5]
  • Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 (#1297) [558f6e0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#1307) [84ff7f3]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.15.0

Features

  • JUnit reports now interpret Label(owner:X) and set owner to X. [8f3bd70]
  • include cancellation reason when cancelling spec context [96e915c]

Fixes

  • emit output of failed go tool cover invocation so users can try to debug things for themselves [c245d09]
  • fix outline when using nodot in ginkgo v2 [dca77c8]
  • Document areas where GinkgoT() behaves differently from testing.T [dbaf18f]
  • bugfix(docs): use Unsetenv instead of Clearenv (#1337) [6f67a14]

Maintenance

  • Bump to go 1.20 [4fcd0b3]

2.14.0

Features

You can now use GinkgoTB() when you need an instance of testing.TB to pass to a library.

Prior to this release table testing only supported generating individual Its for each test entry. DescribeTableSubtree extends table testing support to entire testing subtrees - under the hood DescrieTableSubtree generates a new container for each entry and invokes your function to fill our the container. See the docs to learn more.

  • Introduce DescribeTableSubtree [65ec56d]
  • add GinkgoTB() to docs [4a2c832]
  • Add GinkgoTB() function (#1333) [92b6744]

Fixes

  • Fix typo in internal/suite.go (#1332) [beb9507]
  • Fix typo in docs/index.md (#1319) [4ac3a13]
  • allow wasm to compile with ginkgo present (#1311) [b2e5bc5]

Maintenance

  • Bump golang.org/x/tools from 0.16.0 to 0.16.1 (#1316) [465a8ec]
  • Bump actions/setup-go from 4 to 5 (#1313) [eab0e40]
  • Bump github/codeql-action from 2 to 3 (#1317) [fbf9724]
  • Bump golang.org/x/crypto (#1318) [3ee80ee]
  • Bump golang.org/x/tools from 0.14.0 to 0.16.0 (#1306) [123e1d5]
  • Bump github.com/onsi/gomega from 1.29.0 to 1.30.0 (#1297) [558f6e0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#1307) [84ff7f3]
Commits
  • 7fa0190 v2.15.0
  • c245d09 emit output of failed go tool cover invocation so users can try to debug thin...
  • dca77c8 fix outline when using nodot inginkgo v2
  • 96e915c include cancellation reason when cancelling spec context
  • 4fcd0b3 Bump to go 1.20
  • 732abbc clarify that last owner label wins
  • 8f3bd70 JUnit reports now interpret Label(owner:X) and set owner to X.
  • dbaf18f Document areas where GinkgoT() behaves differently from testing.T
  • 6f67a14 bugfix(docs): use Unsetenv instead of Clearenv (#1337)
  • beaf16d v2.14.0
  • Additional commits viewable in compare view


Updates github.com/onsi/gomega from 1.30.0 to 1.31.1

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.31.1

1.31.1

Fixes

  • Inverted arguments order of FailureMessage of BeComparableToMatcher [e0dd999]
  • Update test in case keeping msg is desired [ad1a367]

Maintenance

  • Show how to import the format sub package [24e958d]
  • tidy up go.sum [26661b8]
  • bump dependencies [bde8f7a]

v1.31.0

1.31.0

Features

  • Async assertions include context cancellation cause if present [121c37f]

Maintenance

  • Bump minimum go version [dee1e3c]
  • docs: fix typo in example usage "occured" -> "occurred" [49005fe]
  • Bump actions/setup-go from 4 to 5 (#714) [f1c8757]
  • Bump github/codeql-action from 2 to 3 (#715) [9836e76]
  • Bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.2 (#713) [54726f0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#711) [df97ecc]
  • docs: fix HaveExactElement typo (#712) [a672c86]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.31.1

Fixes

  • Inverted arguments order of FailureMessage of BeComparableToMatcher [e0dd999]
  • Update test in case keeping msg is desired [ad1a367]

Maintenance

  • Show how to import the format sub package [24e958d]
  • tidy up go.sum [26661b8]
  • bump dependencies [bde8f7a]

1.31.0

Features

  • Async assertions include context cancellation cause if present [121c37f]

Maintenance

  • Bump minimum go version [dee1e3c]
  • docs: fix typo in example usage "occured" -> "occurred" [49005fe]
  • Bump actions/setup-go from 4 to 5 (#714) [f1c8757]
  • Bump github/codeql-action from 2 to 3 (#715) [9836e76]
  • Bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.2 (#713) [54726f0]
  • Bump golang.org/x/net from 0.17.0 to 0.19.0 (#711) [df97ecc]
  • docs: fix HaveExactElement typo (#712) [a672c86]
Commits
  • 762b171 v1.31.1
  • 26661b8 tidy up go.sum
  • bde8f7a bump dependencies
  • 24e958d Show how to import the format sub package
  • ad1a367 Update test in case keeping msg is desired
  • e0dd999 Inverted arguments order of FailureMessage of BeComparableToMatcher
  • ba8bba2 v1.31.0
  • 121c37f Async assertions include context cancellation cause if present
  • dee1e3c Bump minimum go version
  • 49005fe docs: fix typo in example usage "occured" -> "occurred"
  • Additional commits viewable in compare view


Updates github.com/emicklei/go-restful/v3 from 3.11.0 to 3.11.2

Changelog

Sourced from github.com/emicklei/go-restful/v3's changelog.

[v3.11.1, v3.11.2] - 2024-01-09

  • fix by restoring custom JSON handler functions (Mike Beaumont #540)
Commits
  • 0b7e009 fix: restore ability to customize JSON handling (#540)
  • 290805f remove the dependency on github.com/json-iterator/go. (#539)
  • aaf45fd reduce dependencies, add test code for examples
  • a328c20 update all tests to use 3.11
  • See full diff in compare view


Updates github.com/evanphx/json-patch from 5.7.0+incompatible to 5.9.0+incompatible

Release notes

Sourced from github.com/evanphx/json-patch's releases.

v5.9.0

What's Changed

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.8.1...v5.9.0

Fix API breakage

This PR fixes Operation containing a reference to internal/json and breaking the ability to manually compose one. This restores that ability using a type alias.

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.8.0...v5.8.1

Blargh Phixs and Empathyprovements

This release fixes a few stray panics, addresses large number accuracy, and improves performance!

What's Changed

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.7.0...v5.8.0

Commits
  • b7a4e4a Merge pull request #202 from evanphx/f-html-escape
  • 7eef36c Guard using options to avoid a crash bug
  • 1bcbd0f Merge pull request #201 from evanphx/b-null
  • 9d7ba23 Add option to control if the output is HTMLEscaped
  • 009bc56 Validate that the partialDoc is decoded correctly
  • b82b685 Use a type alias for RawMessage to avoid breaking the public API of Operation
  • 05c9526 Merge pull request #197 from evanphx/f-perf
  • 7a438a6 Minor simplifications
  • 2a122d1 More optimizations
  • 174e1d7 Add MergePatch benchmark
  • Additional commits viewable in compare view


Updates github.com/evanphx/json-patch/v5 from 5.7.0 to 5.9.0

Release notes

Sourced from github.com/evanphx/json-patch/v5's releases.

v5.9.0

What's Changed

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.8.1...v5.9.0

Fix API breakage

This PR fixes Operation containing a reference to internal/json and breaking the ability to manually compose one. This restores that ability using a type alias.

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.8.0...v5.8.1

Blargh Phixs and Empathyprovements

This release fixes a few stray panics, addresses large number accuracy, and improves performance!

What's Changed

Full Changelog: https://github.com/evanphx/json-patch/compare/v5.7.0...v5.8.0

Commits
  • b7a4e4a Merge pull request #202 from evanphx/f-html-escape
  • 7eef36c Guard using options to avoid a crash bug
  • 1bcbd0f Merge pull request #201 from evanphx/b-null
  • 9d7ba23 Add option to control if the output is HTMLEscaped
  • 009bc56 Validate that the partialDoc is decoded correctly
  • b82b685 Use a type alias for RawMessage to avoid breaking the public API of Operation
  • 05c9526 Merge pull request #197 from evanphx/f-perf
  • 7a438a6 Minor simplifications
  • 2a122d1 More optimizations
  • 174e1d7 Add MergePatch benchmark
  • Additional commits viewable in compare view


Updates github.com/go-logr/logr from 1.3.0 to 1.4.1

Release notes

Sourced from github.com/go-logr/logr's releases.

v1.4.1

What's Changed

Full Changelog: https://github.com/go-logr/logr/compare/v1.4.0...v1.4.1

v1.4.0

This release dramatically improves interoperability with Go's log/slog package. In particular, logr.NewContext and logr.NewContextWithSlogLogger use the same context key, which allows logr.FromContext and logr.FromContextAsSlogLogger to return logr.Logger or *slog.Logger respectively, including transparently converting each to the other as needed.

Functions logr/slogr.NewLogr and logr/slogr.ToSlogHandler have been superceded by logr.FromSlogHandler and logr.ToSlogHandler respectively, and type logr/slogr.SlogSink has been superceded by logr.SlogSink. All of the old names in logr/slogr remain, for compatibility.

Package logr/funcr now supports logr.SlogSink, meaning that it's output passes all but one of the Slog conformance tests (that exception being that funcr handles the timestamp itself).

Users who have a logr.Logger and need a *slog.Logger can call slog.New(logr.ToSlogHandler(...)) and all output will go through the same stack.

Users who have a *slog.Logger or slog.Handler can call logr.FromSlogHandler(...) and all output will go through the same stack.

What's Changed

New Contributors

Full Changelog: https://github.com/go-logr/logr/compare/v1.3.0...v1.4.0

Commits
  • dcdc3f2 slogr: fix unintended API break in v0.8.0 (#253)
  • 5d88f52 funcr: Add LogInfoLevel Option to skip logging level in the info log (#240)
  • 177005d build(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0
  • e7f489a build(deps): bump github/codeql-action from 2.22.9 to 3.22.11
  • cf56c3b build(deps): bump actions/setup-go from 4 to 5
  • 2ad296e build(deps): bump github/codeql-action from 2.22.8 to 2.22.9
  • d55b4e2 Merge pull request #241 from thockin/master
  • 98ee9d9 Clean up slog testing and restore coverage
  • b228ba8 Break examples to new file
  • 6432877 Add benchmarks for slogSink
  • Additional commits viewable in compare view


Updates github.com/go-openapi/jsonpointer from 0.20.1 to 0.20.2

Commits
  • 344388f fix(GetForToken): added support for pointer to interface{}
  • See full diff in compare view


Updates github.com/go-openapi/jsonreference from 0.20.3 to 0.20.4

Commits


Updates github.com/go-openapi/swag from 0.22.5 to 0.22.6

Commits
  • 11b0957 fix(yaml): make MarshalYAML deterministic
  • 3f60c98 fix(yaml): handled null values from JSON
  • See full diff in compare view


Updates github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.1 to 2.19.1

Release notes

Sourced from github.com/grpc-ecosystem/grpc-gateway/v2's releases.

v2.19.1

What's Changed

New Contributors

Full Changelog: https://github.com/grpc-ecosystem/grpc-gateway/compare/v2.19.0...v2.19.1

v2.19.0

What's Changed

New Contributors

Full Changelog: https://github.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0

Commits
  • 0bcc6bf fix path param override by query params (#3946)
  • 8f860cf chore(deps): update googleapis digest to d638535
  • 5a55932 chore(deps): update googleapis digest to 11c5a8b
  • 5e20b2e chore(deps): update googleapis digest to 9847acc
  • d1db865 chore(deps): update googleapis digest to 27c16bb
  • 80e1f52 fix(deps): update google.golang.org/genproto/googleapis/api digest to 1f4bbc5
  • cfec40d fix(deps): update google.golang.org/genproto/googleapis/rpc digest to 1f4bbc5
  • 3e31a0f chore(deps): update dependency bazel to v7.0.2
  • 313a7c3 chore(deps): update googleapis digest to 8169878
  • e5d2c70 chore(deps): update googleapis digest to 6f0527b
  • Additional commits viewable in compare view


Updates github.com/prometheus/common from 0.45.0 to 0.46.0

Release notes

Sourced from github.com/prometheus/common's releases.

v0.46.0

What's Changed

k8s-ci-robot commented 4 months ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xing-yang commented 4 months ago

/lgtm /approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-provisioner/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment