kubernetes-csi / external-provisioner

Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint
Apache License 2.0
338 stars 324 forks source link

promote HonorReclaimPolicy to beta #1209

Closed carlory closed 4 months ago

carlory commented 4 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

https://github.com/kubernetes/kubernetes/pull/123151 adds e2e tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Promote HonorPVReclaimPolicy to beta.
carlory commented 4 months ago

need to update sig-storage-lib-external-provisioner dep to v10.0.0

I0513 07:13:10.887711       1 controller.go:1561] delete "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8": failed to remove finalizer for persistentvolume: persistentvolumes "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8" is forbidden: User "system:serviceaccount:default:csi-provisioner" cannot update resource "persistentvolumes" in API group "" at the cluster scope
W0513 07:13:10.887758       1 controller.go:989] Retrying syncing volume "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8", failure 0
E0513 07:13:10.887807       1 controller.go:1007] error syncing volume "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8": persistentvolumes "pvc-23da1f27-e7ec-41f6-943a-f52db1e018b8" is forbidden: User "system:serviceaccount:default:csi-provisioner" cannot update resource "persistentvolumes" in API group "" at the cluster scope
carlory commented 4 months ago

cc @jsafrane @xing-yang

jsafrane commented 4 months ago

external-provisioner was updated /retest

jsafrane commented 4 months ago

/lgtm /approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-provisioner/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment