kubernetes-csi / external-provisioner

Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint
Apache License 2.0
338 stars 324 forks source link

fix: introduce /v5 module suffix for go.mod #1236

Closed jakobmoellerdev closed 2 months ago

jakobmoellerdev commented 3 months ago

changes the go.mod path to add /v5 so that go module is resolved properly

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Adds the /v5 suffix that was missed on previous releases so that the go.mod resolves properly

Special notes for your reviewer:

Opened as per request on https://kubernetes.slack.com/archives/C09QZFCE5/p1718782253879689

Does this PR introduce a user-facing change?:

action required: go module path was changed to github.com/kubernetes-csi/external-provisioner/v5, adjust accordingly when importing in go
k8s-ci-robot commented 3 months ago

Hi @jakobmoellerdev. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
msau42 commented 3 months ago

/ok-to-test

jakobmoellerdev commented 3 months ago

@msau42 I think https://github.com/kubernetes-csi/external-provisioner/blob/c66e140569df5ef776a1e16812422f63405f2d36/.prow.sh#L3 is problematic because it is both a go import path as well as a directory path and now these 2 diverge with the /v5 bump. I believe that release tooling uses it as a path in https://github.com/kubernetes-csi/external-provisioner/blob/e96448ac2fb9cd15e681bd697c632fc32e580450/release-tools/prow.sh#L1038 and as a go import in https://github.com/kubernetes-csi/external-provisioner/blob/e96448ac2fb9cd15e681bd697c632fc32e580450/release-tools/prow.sh#L977

Any preference on how to fix that?

msau42 commented 3 months ago

@jakobmoellerdev What do you think of creating a new variable? Edits to release-tools need to be done in https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh? first and than imported here as a git submodule (instructions are in the repo)

jakobmoellerdev commented 3 months ago

@msau42 I would need a checkup on the tools PR so that we can unblock that.

jakobmoellerdev commented 2 months ago

/retest

jakobmoellerdev commented 2 months ago

@msau42 thanks to the adjustment in the release tooling this one is now good to go :+1:

msau42 commented 2 months ago

/lgtm /approve

Thanks!

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-provisioner/blob/master/OWNERS)~~ [msau42] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment