Closed jakobmoellerdev closed 2 months ago
Hi @jakobmoellerdev. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@msau42 I think https://github.com/kubernetes-csi/external-provisioner/blob/c66e140569df5ef776a1e16812422f63405f2d36/.prow.sh#L3 is problematic because it is both a go import path as well as a directory path and now these 2 diverge with the /v5 bump. I believe that release tooling uses it as a path in https://github.com/kubernetes-csi/external-provisioner/blob/e96448ac2fb9cd15e681bd697c632fc32e580450/release-tools/prow.sh#L1038 and as a go import in https://github.com/kubernetes-csi/external-provisioner/blob/e96448ac2fb9cd15e681bd697c632fc32e580450/release-tools/prow.sh#L977
Any preference on how to fix that?
@jakobmoellerdev What do you think of creating a new variable? Edits to release-tools need to be done in https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh? first and than imported here as a git submodule (instructions are in the repo)
@msau42 I would need a checkup on the tools PR so that we can unblock that.
/retest
@msau42 thanks to the adjustment in the release tooling this one is now good to go :+1:
/lgtm /approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jakobmoellerdev, msau42
The full list of commands accepted by this bot can be found here.
The pull request process is described here
changes the go.mod path to add /v5 so that go module is resolved properly
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds the /v5 suffix that was missed on previous releases so that the go.mod resolves properly
Special notes for your reviewer:
Opened as per request on https://kubernetes.slack.com/archives/C09QZFCE5/p1718782253879689
Does this PR introduce a user-facing change?: