search

kubernetes-csi / external-resizer

Sidecar container that watches Kubernetes PersistentVolumeClaims objects and triggers controller side expansion operation against a CSI endpoint
Apache License 2.0
126 stars 130 forks source link

Fix panic if unable to update PVC #246

Closed gnufied closed 1 year ago

gnufied commented 1 year ago

This fixes a panic in code that assumes a PVC is returned even if update of PVC fails.

It only happens in path that runs recovery from expansion failure code.

Fix panic in recovery path if marking pvc as resize in progress fails
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-resizer/blob/master/OWNERS)~~ [gnufied] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dobsonj commented 1 year ago

/lgtm