search

kubernetes-csi / external-resizer

Sidecar container that watches Kubernetes PersistentVolumeClaims objects and triggers controller side expansion operation against a CSI endpoint
Apache License 2.0
125 stars 126 forks source link

Update dependency go modules for k8s v1.28.0-rc.0 #317

Closed sunnylovestiramisu closed 1 year ago

sunnylovestiramisu commented 1 year ago

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0-rc.0

k8s-ci-robot commented 1 year ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunnylovestiramisu Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/external-resizer/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

@sunnylovestiramisu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-external-resizer-1-26-on-kubernetes-1-26 4dc65b78717463c05d11112985c097f94468cc08 link false /test pull-kubernetes-csi-external-resizer-1-26-on-kubernetes-1-26
pull-kubernetes-csi-external-resizer-unit 4dc65b78717463c05d11112985c097f94468cc08 link true /test pull-kubernetes-csi-external-resizer-unit
pull-kubernetes-csi-external-resizer-1-25-on-kubernetes-1-25 4dc65b78717463c05d11112985c097f94468cc08 link true /test pull-kubernetes-csi-external-resizer-1-25-on-kubernetes-1-25
pull-kubernetes-csi-external-resizer-1-24-on-kubernetes-1-24 4dc65b78717463c05d11112985c097f94468cc08 link true /test pull-kubernetes-csi-external-resizer-1-24-on-kubernetes-1-24

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gnufied commented 1 year ago

hmm, should we update this with https://github.com/kubernetes-csi/external-resizer/pull/270 ? I was doing that anyways as part of updating the sidecar

sunnylovestiramisu commented 1 year ago

@gnufied I was not aware of you are working on it already, and yep if you are taking care if it in your PR#270, we do not need to do it in this PR.

gnufied commented 1 year ago

Yeah I will have to modify some logic issues too while I am changing the code to use newer APIs. So it is best we handle this via #270

sunnylovestiramisu commented 1 year ago

/close

k8s-ci-robot commented 1 year ago

@sunnylovestiramisu: Closed this PR.

In response to [this](https://github.com/kubernetes-csi/external-resizer/pull/317#issuecomment-1671789360): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.