Closed gnufied closed 3 weeks ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnufied
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@jsafrane okay I have pushed a change that completely removes attempts to slow retries of recovery from NodeInfeasible
volume errors. We will revisit this aspect later.
/lgtm
This PR bumps go version to 1.22.5, which breaks our internal CI. Should we also update this line? We use this to determine the go version used to build it.
Why prow job does not fail. I expect the prow job also use this info.
update:
Thu Aug 15 19:50:18 UTC 2024 go1.22.5 $ curl --fail --location https://dl.google.com/go/go1.22.3.linux-amd64.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
20 65.7M 20 13.3M 0 0 18.7M 0 0:00:03 --:--:-- 0:00:03 18.7M
54 65.7M 54 35.9M 0 0 20.7M 0 0:00:03 0:00:01 0:00:02 20.7M
70 65.7M 70 46.4M 0 0 16.4M 0 0:00:03 0:00:02 0:00:01 16.4M
86 65.7M 86 56.9M 0 0 14.8M 0 0:00:04 0:00:03 0:00:01 14.8M
100 65.7M 100 65.7M 0 0 13.2M 0 0:00:04 0:00:04 --:--:-- 13.2M
100 65.7M 100 65.7M 0 0 13.2M 0 0:00:04 0:00:04 --:--:-- 12.2M
go: downloading go1.22.5 (linux/amd64)
It seems we have tried to install 1.22.3, but go upgraded itself to 1.22.5. Should we set GOTOOLCHAIN=local
to disable this auto upgrade? So that we will have more reproducible and predictable build.
I'l updating release-tools in https://github.com/kubernetes-csi/external-resizer/pull/431
Implements less noisy error reporting when expansion fails.