kubernetes-csi / external-resizer

Sidecar container that watches Kubernetes PersistentVolumeClaims objects and triggers controller side expansion operation against a CSI endpoint
Apache License 2.0
123 stars 123 forks source link

Skip modifying volumes owned by other CSI drivers #419

Closed ConnorJC3 closed 1 month ago

ConnorJC3 commented 1 month ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes issue (3) from https://github.com/kubernetes/kubernetes/pull/124151#issuecomment-2152647568 - Today, the external-resizer will attempt to modify any PVC awaiting modification without checking for if it matches the local CSI driver.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

No test exercises syncPVC, so I could not update the tests for this case. I have manually tested the change against multiple drivers.

Does this PR introduce a user-facing change?:

Fixed a bug causing external-resizer to attempt to modify volumes owned by other CSI drivers
msau42 commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-resizer/blob/master/OWNERS)~~ [msau42] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msau42 commented 1 month ago

/cherry-pick release-1.11

k8s-infra-cherrypick-robot commented 1 month ago

@msau42: new pull request created: #422

In response to [this](https://github.com/kubernetes-csi/external-resizer/pull/419#issuecomment-2253122678): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.