Closed huww98 closed 3 months ago
Hi @huww98. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Also, I am somewhat surprised that we aren't running our unit tests with -race
flag. May be, we should. I don't see an obvious downside.
/ok-to-test
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnufied, huww98
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind bug /kind failing-test
What this PR does / why we need it:
Reported by
go test -race
. Also use time.Ticker to response faster to stopCh.Which issue(s) this PR fixes:
Fixes #418 Fixes 99cf66fd7606604ac3dd101b6a8141d9ff9a1366
Special notes for your reviewer:
/cc @gnufied @jsafrane
Does this PR introduce a user-facing change?: