search

kubernetes-csi / external-snapshot-metadata

This repo contains sidecar controller for the snapshot metadata service.
Apache License 2.0
4 stars 8 forks source link

Add new SnapshotMetadataService CR object #2

Closed PrasadG193 closed 4 months ago

PrasadG193 commented 5 months ago

This PR contains:

carlbraganza commented 5 months ago

I think you should add a top-level Makefile rule (no-default) to regenerate the CR files. That should address the lack of transparency in how these files get created.

PrasadG193 commented 4 months ago

/release-note-none

carlbraganza commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

@carlbraganza: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-csi/external-snapshot-metadata/pull/2#issuecomment-2176645171): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
carlbraganza commented 4 months ago

/lgtm

carlbraganza commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlbraganza, PrasadG193

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/OWNERS)~~ [PrasadG193,carlbraganza] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
carlbraganza commented 4 months ago

/lgtm