Closed dependabot[bot] closed 8 months ago
Hi @dependabot[bot]. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dependabot[bot] Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/test pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-1-29
@dependabot[bot]: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-1-29 | b3f052a19d12856ab798b0830f1e45cd4a3ef06a | link | false | /test pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-1-29 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
It appears that the 1.29 job does not pick up this change: https://github.com/kubernetes-csi/csi-release-tools/pull/246/files
It seems to pick up the minimum golang version for K8s 1.29: https://github.com/kubernetes/kubernetes/blob/v1.29.0/hack/lib/golang.sh#L500
https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L562
go_version_for_kubernetes () (
local path="$1"
local version="$2"
local go_version
# We use the minimal Go version specified for each K8S release (= minimum_go_version in hack/lib/golang.sh).
# More recent versions might also work, but we don't want to count on that.
go_version="$(grep minimum_go_version= "$path/hack/lib/golang.sh" | sed -e 's/.*=go//')"
if ! [ "$go_version" ]; then
die "Unable to determine Go version for Kubernetes $version from hack/lib/golang.sh."
fi
# Strip the trailing .0. Kubernetes includes it, Go itself doesn't.
# Ignore: See if you can use ${variable//search/replace} instead.
# shellcheck disable=SC2001
go_version="$(echo "$go_version" | sed -e 's/\.0$//')"
echo "$go_version"
)
However, go1.21.linux-amd64.tar.gz does not exist.
Fri Feb 16 15:00:38 UTC 2024 go1.22.0 /home/prow/go/pkg/csiprow.XBzTGe3OIr/src/kubernetes$ curl --fail --location https://dl.google.com/go/go1.21.linux-amd64.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 1449 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404
gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
ERROR: installation of Go 1.21 failed
ERROR: 'kind build node-image' failed
@pohly We started to see this failure after adding 1.29 jobs. It looks like it always picks up the minimum golang version (1.21) for K8s 1.29 for 1.29 jobs. However, for 1.28 and earlier jobs, it uses CSI_PROW_GO_VERSION_BUILD "1.21.5"
from prow.sh. Any idea how to fix this?
Superseded by #1021.
Bumps github.com/prometheus/common from 0.46.0 to 0.47.0.
Release notes
Sourced from github.com/prometheus/common's releases.
Commits
773d566
Merge pull request #570 from ywwg/owilliams/quoted-metric-name-02319c62c
UTF-8 support in metric and label namesa3bdb9e
Support empty OAuth2 inline secrets (#547)bd0376d
UTF-8 support in validation, and some parsers and formatters (#537)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show