Closed Lyndon-Li closed 1 month ago
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
What happened: In v7.0.1 since
prevent-volume-mode-conversion
is enabled by default, the created volumesnapshotcotent sets itsspec.SourceVolumeMode
by inheriting value from the source PVC, so it must not be nil. On the other hand, in v7.0.1, there is a change #1005 where the webhook fails the validation of updating volumesnapshotcotent ifoldSnapcontent.Spec.SourceVolumeMode != nil && newSnapcontent.Spec.SourceVolumeMode == nil
.However, it is possible that for a client that is using an older version of external-snapshotter API,
spec.SourceVolumeMode
field does not exist in volumesnapshotcotent's spec. If the Update method is called through this old client, it falls intooldSnapcontent.Spec.SourceVolumeMode != nil && newSnapcontent.Spec.SourceVolumeMode == nil
, as a result, the Update will fail.What you expected to happen: Update method should succeed even
spec.SourceVolumeMode
is not definedHow to reproduce it: See Velero issue https://github.com/vmware-tanzu/velero/issues/7433
Anything else we need to know?:
Environment:
kubectl version
):uname -a
):