Closed kaovilai closed 6 months ago
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Hi @kaovilai. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kaovilai Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Closing due to other priorities as the sense is this isn't going to be approved as is and to see if #876 recently cherrypicked to our nightlies would be sufficient. Feel free to takeover.
Test improvements are moved to #1024
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
What type of PR is this?
What this PR does / why we need it: This PR cleans up some of the unit test reactor code, and eliminate update calls that I can see, fixing unit tests to accommodate the changes. Previously update call was required simply cause unit test is borked. Patch calls was modifying original input causing compare failures. Which issue(s) this PR fixes:
Fixes #748
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
This PR extend https://github.com/kubernetes-csi/external-snapshotter/pull/876 work to later added update calls.
Similar to #1019 but using Update calls for finalizer removal.