search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
471 stars 363 forks source link

[release-7.0] fix: use groupsnapshot secret for group operation #1056

Closed Madhu-1 closed 3 months ago

Madhu-1 commented 5 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Use the right groupsnapshot secret for the group operations.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com (cherry picked from commit 30b24e6a0e424485c0149757caa2c975fba4bd37)

This is backport of #1048

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cherry-pick from PR [#1048](https://github.com/kubernetes-csi/external-snapshotter/pull/1048) Adds secret reference to volume group snapshot content.
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1 Once this PR has been reviewed and has the lgtm label, please assign yuxiangqian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/release-7.0/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 months ago

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Madhu-1 commented 5 months ago

/assign @xing-yang

xing-yang commented 4 months ago

/ok-to-test

Madhu-1 commented 3 months ago

@xing-yang is this good to get merged?

xing-yang commented 3 months ago

@xing-yang is this good to get merged?

@Madhu-1 Same as the other PR. We are going to cut a new release soon. I wonder if we still need to patch this in 7.0 branch.

Madhu-1 commented 3 months ago

@xing-yang is this good to get merged?

@Madhu-1 Same as the other PR. We are going to cut a new release soon. I wonder if we still need to patch this in 7.0 branch.

Thank you. got it, closing this as not required anymore.