search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
463 stars 361 forks source link

Update manifests based on new CRD validation rules #1076

Closed xing-yang closed 2 months ago

xing-yang commented 2 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: Update manifests with controller-gen@v0.15.0 and validation rules added by https://github.com/kubernetes-csi/external-snapshotter/pull/1073.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: This PR depends on https://github.com/kubernetes-csi/external-snapshotter/pull/1073.

Does this PR introduce a user-facing change?:

Update manifests with controller-gen@v0.15.0 and new validation rules. Minimum required Kubernetes version is 1.25 for these validation rules.
xing-yang commented 2 months ago

/hold

xing-yang commented 2 months ago

/hold cancel

leonardoce commented 2 months ago

I run my YAML test suite over this branch, and everything is right. I manually created a volumesnapshot and deleted it, and did the same with a volumegroupsnapshot (using the hostpath.csi.k8s.io driver) Everything looks good to me.

leonardoce commented 2 months ago

The CRD definition is ok, too, compared with the one generated by the ./hack/update-crd.sh script.

leonardoce commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

@leonardoce: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-csi/external-snapshotter/pull/1076#issuecomment-2099791258): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
deepakkinni commented 2 months ago

/approve /lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment