Closed leonardoce closed 2 months ago
Hi @leonardoce. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I'm not 100% sure which directory to add these test cases to. Any feedback is greatly appreciated. cc: @xing-yang
/ok-to-test
I rebased it and tested it against the new master
, and everything is still green. Thanks @xing-yang!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leonardoce, xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
What this PR does / why we need it:
This patch adds several YAML test cases that check if the CEL rules included in the CRDs are correctly working. Both validation rules and transition rules are checked.
A shell script is provided to execute these tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: