search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
483 stars 367 forks source link

Add metrics for Volume Group Snapshot #1081

Closed xing-yang closed 2 months ago

yati1998 commented 5 months ago

Hi @xing-yang , Can you please add more details on what metrics need to be added and for what purpose?

xing-yang commented 5 months ago

We'll need to add metrics for snapshot-controller, similar to what we've added for volume snapshots. See example here: https://github.com/kubernetes-csi/external-snapshotter/blob/master/pkg/metrics/metrics_test.go#L256

yati1998 commented 3 months ago

https://github.com/kubernetes-csi/external-snapshotter/pull/1107, we can close this issue now.

Madhu-1 commented 2 months ago

@xing-yang can we close this one?