search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
463 stars 361 forks source link

Ensure vendor checks are run for all modules #1085

Closed bells17 closed 2 months ago

bells17 commented 2 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As observed in the PR below, the current vendor tests might not always detect if go mod tidy or similar commands have been run in the external-snapshotter when changes are made in the client module. https://github.com/kubernetes-csi/external-snapshotter/pull/1073

To address this, in this PR, I have made the following enhancements:

  1. Added vendor checks for the client module
  2. Enhanced vendor checks for the external-snapshotter

These changes aim to reduce the risk of vendor updates being overlooked.

refs:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
bells17 commented 2 months ago

/cc @xing-yang

xing-yang commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bells17, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment