kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
463 stars 361 forks source link

Avoid group snapshot provisioning with mismatching CSI Drivers #1098

Closed leonardoce closed 1 month ago

leonardoce commented 1 month ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Check whether the volumes to be snapshotted in a group belong to the CSI driver referenced in the VolumeGroupSnapshot resource.

Which issue(s) this PR fixes:

Fixes #1096

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Prevents a VolumeGroupSnapshot to be provisioned when the volumes' CSI driver is different from the one referenced in the VolumeGroupSnapshotClass resource
leonardoce commented 1 month ago

Thank you @Madhu-1!

Madhu-1 commented 1 month ago

/lgtm

/assign @xing-yang for approval

k8s-ci-robot commented 1 month ago

@Madhu-1: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes-csi members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-csi/external-snapshotter/pull/1098#issuecomment-2133442235): >/lgtm > >/assign @xing-yang for approval Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
xing-yang commented 1 month ago

/retest

xing-yang commented 1 month ago

Can you rebase? The spelling errors are fixed now.

leonardoce commented 1 month ago

Done @xing-yang

xing-yang commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardoce, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment