search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
463 stars 361 forks source link

refactor controllers to use patch to update snapshot status #1110

Open hoyho opened 1 month ago

hoyho commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: snapshot-controller logs report failure frequently

Which issue(s) this PR fixes:

Fixes #748

Special notes for your reviewer: Someone had partially fixed some of calls see https://github.com/kubernetes-csi/external-snapshotter/pull/876. This PR is going to focus on remained UpdateStatus.

Does this PR introduce a user-facing change?:

Use patch to update snapshot and snapshotContent to reduce conflicts
k8s-ci-robot commented 1 month ago

Hi @hoyho. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hoyho Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xing-yang commented 1 month ago

/ok-to-test