search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
463 stars 361 forks source link

Look for a VolumeGroupSnapshotClass when getting the class of a VolumeGroupSnapshot #1115

Open leonardoce opened 2 weeks ago

leonardoce commented 2 weeks ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

When looking for the name of the CSI driver to use for a volume group snapshot, we were looking for a VolumeSnapshotClass instead of a VolumeGroupSnapshotClass. This made the VolumeGroupSnapshot fail when there is no such VolumeGroupSnapshotClass.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Look for a VolumeGroupSnapshotClass instead of a VolumeSnapshotClass when getting metrics data for VolumeGroupSnapshot metrics.
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leonardoce Once this PR has been reviewed and has the lgtm label, please assign yuxiangqian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Madhu-1 commented 2 weeks ago

/lgtm /assign @xing-yang