Closed leonardoce closed 1 month ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
I would suggest to add the test for create,delete, update in single file
Thank you, @yati1998, for having a look. I split the unit tests because that's what it was done for volume snapshots. Do you think it would better for volume group snapshots to have a different approach?
Thank you @Madhu-1!
Done @xing-yang, and thanks for the advice. I also added another test for pre-provisioned volume group snapshots, testing the mismatch between a pre-provisioned volume group snapshot and a dynamically-provisioned volume group snapshot content.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leonardoce, xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
What this PR does / why we need it:
Adds unit tests for the group snapshot controller.
Which issue(s) this PR fixes:
Fixes #1082
Special notes for your reviewer:
Does this PR introduce a user-facing change?: