kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
484 stars 369 forks source link

Add group snapshot controller unit tests #1118

Closed leonardoce closed 1 month ago

leonardoce commented 3 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Adds unit tests for the group snapshot controller.

Which issue(s) this PR fixes:

Fixes #1082

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

leonardoce commented 2 months ago

I would suggest to add the test for create,delete, update in single file

Thank you, @yati1998, for having a look. I split the unit tests because that's what it was done for volume snapshots. Do you think it would better for volume group snapshots to have a different approach?

leonardoce commented 1 month ago

Thank you @Madhu-1!

leonardoce commented 1 month ago

Done @xing-yang, and thanks for the advice. I also added another test for pre-provisioned volume group snapshots, testing the mismatch between a pre-provisioned volume group snapshot and a dynamically-provisioned volume group snapshot content.

xing-yang commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardoce, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment