Open manishym opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: manishym Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @manishym. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/retest
Can you please rebase?
groupSnapshotContent
is not nil indeleteCSIGroupSnapshotOperation
to prevent panics.SnapshotHandle
inVolumeSnapshotContent
objects during deletion.groupsnapshot_helper_test.go
to cover cases wheregroupSnapshotContent
is nil or incomplete.What type of PR is this?
What this PR does / why we need it: Before fix:
After fix:
Which issue(s) this PR fixes:
Fixes #1123
Special notes for your reviewer:
Does this PR introduce a user-facing change?: