Prevent a crash loop caused by upstream changes

[ejweber]

What type of PR is this?

/kind bug

What this PR does / why we need it:

See https://github.com/kubernetes-csi/livenessprobe/issues/236 and https://github.com/longhorn/longhorn/issues/7116 for a complete analysis.

Now that csi-lib-utils.Connect returns after a configurable 30 second timeout:

• We need to ensure livenessprobe and its CSI plugin don't enter an unrecoverable alternating crash loop that prevents liveness probes from ever succeeding. We do this by setting the connection timeout during initialization to five minutes.
• We can do away with the acquireConnection wrapper function, which previously implemented timeouts at the livenessprobe layer. These timeouts can now simply be passed to the csi-lib-utils layer.

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-csi/livenessprobe/issues/236

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ejweber Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-csi/livenessprobe/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[k8s-ci-robot]

Welcome @ejweber!

It looks like this is your first PR to kubernetes-csi/livenessprobe 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/livenessprobe has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @ejweber. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[jsafrane]

/ok-to-test

[ejweber]

There is a competing PR in https://github.com/kubernetes-csi/livenessprobe/pull/240 that takes a similar, but improved approach. It is driven by an official maintainer, so it has a good chance of success. Closing this one in favor of that one.