search

kubernetes-csi / livenessprobe

A sidecar container that can be included in a CSI plugin pod to enable integration with Kubernetes Liveness Probe.
Apache License 2.0
72 stars 94 forks source link

need version compatibility for windows 2022 #243

Closed thdrnsdk closed 5 months ago

thdrnsdk commented 6 months ago

in the repo dockerfile.windows there is base, addon image is windwos images "1809"

Images created in this way do not seem to work on Windows 2022 servers due to version compatibility issues.

mauriciopoppe commented 6 months ago

Fortunately the values in https://github.com/kubernetes-csi/livenessprobe/blob/ebd49b57031ab90f6f376f1472884948f381558c/Dockerfile.Windows#L16-L17 can be overridden so you're looking at the default values, when we build the images we actually build them with different values seen in https://github.com/kubernetes-csi/livenessprobe/blob/ebd49b57031ab90f6f376f1472884948f381558c/release-tools/prow.sh#L81, the resulting image is a multi-arch image (a docker manifest) that the node will use to determine the right OS/arch combination to download based on the manifest.

In short, I believe we produce image compatible with Windows 2022 too.

andyzhangx commented 5 months ago

/close

k8s-ci-robot commented 5 months ago

@andyzhangx: Closing this issue.

In response to [this](https://github.com/kubernetes-csi/livenessprobe/issues/243#issuecomment-1929604436): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.