Support contextual logging

kubernetes-csi / node-driver-registrar

Sidecar container that registers a CSI driver with the kubelet using the kubelet plugin registration mechanism.

Apache License 2.0

130 stars 134 forks source link

Support contextual logging #410

Closed bells17 closed 4 months ago

bells17 commented 4 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

I've updated the klog functions used within node-driver-registrar to contextual logging functions, following the guidelines below: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Added contextual logging checks using logcheck. (You can run logcheck with make test or make logcheck)

Does this PR introduce a user-facing change?:

Added support for contextual logging.

bells17 commented 4 months ago

/wg structured-logging /priority important-longterm /kind cleanup

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#what-to-include-in-the-pull-request

bells17 commented 4 months ago

/cc @jsafrane

jsafrane commented 4 months ago

/lgtm /approve Thanks a lot!

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bells17, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/node-driver-registrar/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment