search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.08k stars 597 forks source link

Move promgrafonnet to separate repository #331

Open sh0rez opened 4 years ago

sh0rez commented 4 years ago

When installing this library using jb, we end up with the following in jsonnetfile.lock.json:

{
  "name": "promgrafonnet",
  "source": {
    "git": {
      "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin",
      "subdir": "lib/promgrafonnet"
    }
  },
  "version": "20603cc76acdb00363aa3e33006c95d2cfaab0e5",
  "sum": "VhgBM39yv0f4bKv8VfGg4FXkg573evGDRalip9ypKbc="
}

Apparently, some downstream dependency has a dependency on this repo itself .... so we install promgrafonnet twice, which I imagine can become quite unexpected and hard to debug eventually.

What about moving the lib to kubernetes-monitoring/promgrafonnet or grafana/jsonnet-libs/promgrafonnet instead?

/cc @metalmatze @brancz

brancz commented 4 years ago

I'm happy with having it in grafana/jsonnet-libs/promgrafonnet.