search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.11k stars 597 forks source link

[cr] updates KubePodNotReady to use job label #877

Closed jewbetcha closed 1 month ago

jewbetcha commented 1 year ago

To ensure compatibility with new Grafana Alerting structure, this PR updates KubePodNotReady to use the job label.

povilasv commented 12 months ago

I'm not sure about the job label, see discussion in: https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/880

Do you have any reasoning why we need that?

Would be great if we could split this PR into smaller chunks with reasonable PR descriptions, as parts of PR LGTM, parts of PR I'm not sure, etc.

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had any activity in the past 30 days.

The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.

Thank you for your contributions!

skl commented 1 month ago

Closing based on the above, there are a few different changes in this PR which should ideally be isolated into separate branches/PRs.