search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.11k stars 597 forks source link

Dashboards: Fix deeplinks #884

Closed jkroepke closed 8 months ago

jkroepke commented 11 months ago

Since Grafana has a new Table panel (since Grafana 7), the deeplink $__cell isn't working anymore. (at least in Grafana 10.2)

jkroepke commented 11 months ago

Without this, deeplinks are not working

image
jkroepke commented 11 months ago

@povilasv could you take a look here?

povilasv commented 11 months ago

I think we might need to support older versions of grafana, so we cannot merge this. Also see this https://github.com/kubernetes-monitoring/kubernetes-mixin/discussions/864#discussioncomment-7300226

jkroepke commented 11 months ago

I would suggest to drop old grafana versions. Maintain multiple grafana version is a high maintenance effort and its discussable if its worth.

I would drop old version. Old Grafana users can still use old revisions.

In background, kubernetes-mixin depends on the old Table panel which is deprecated for a long time. In thoery, support for that old panel is already gone. Grafana do a auto-converation from old panel to the new one.

Once grafana drops the auto-converation, the whole kubernetes-mixin is useless.

povilasv commented 10 months ago

I agree. But I think instead of doing small fixes like this, let's just refactor to new grafonnet. I think we can add README that x release only supports newest grafana and that's it.

jkroepke commented 8 months ago

I will close this for now. Since it does not work on grafana instances with, if auto-migration of panel is not enabled.

However, Grafana 11 removed support for old table panel. In near future, the dashboard might be outdated anyways.