search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.08k stars 597 forks source link

fix(dashboards): Port kubelet dashboard to new grafonnet #918

Closed rgeyer closed 4 months ago

rgeyer commented 4 months ago

Special note: This includes some drive-by fixes for jsonnet-lint errors which cropped up from previous dashboard updates.

See #922 for the final fix for CI. I put that in a separate PR because it changes a file at the root of the repo (jsonnetfile.json).

Part of:

Following on from:

BEFORE image image image

AFTER image image image

povilasv commented 4 months ago

Looks like this CI is failling https://github.com/kubernetes-monitoring/kubernetes-mixin/actions/runs/8854904985/job/24318871025?pr=918

Other than that LGTM

rgeyer commented 4 months ago

Looks like this CI is failling https://github.com/kubernetes-monitoring/kubernetes-mixin/actions/runs/8854904985/job/24318871025?pr=918

Other than that LGTM

Right! Thanks for catching that.. I pushed and submitted this late on a Friday, and didn't come back to check the CI 😂

rgeyer commented 4 months ago

Hmmn.. Looks like it's failing jsonnet linting from previous merges now 🤔

rgeyer commented 4 months ago

Found the issue(s).. I fixed the linting errors for the other dashboards, as well as the grafana-builder library. See #922 for that fix.